Re: [PATCH v2 1/2] format-patch: create leading components of output directory
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 16 quoted lines
> On one hand, these object ids won't mean much to anyone who might have
> to debug such a test failure in the future, and on the other these
> tests are about 'git format-patch', not about 'git rev-list'. If the
> check were written like this:
>
> count=$(git rev-list --count master..side) &&
> ls patches >list &&
> test_line_count = $count list
>
> then the error message on failure would look something like this:
>
> test_line_count: line count for list != 3
> 0001-first.patch
> 0002-second.patch
>
> which, I think, would be more useful.
That's nice attention to the detail ;-)