git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] format-patch: create leading components of output directory

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 8, 2019, 03:23 UTC
Message-ID
<xmqq8spvor7m.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191007210306.GF11529@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 16 quoted lines
> On one hand, these object ids won't mean much to anyone who might have
> to debug such a test failure in the future, and on the other these
> tests are about 'git format-patch', not about 'git rev-list'.  If the
> check were written like this:
>
>   count=$(git rev-list --count master..side) &&
>   ls patches >list &&
>   test_line_count = $count list
>
> then the error message on failure would look something like this:
>
>   test_line_count: line count for list != 3
>   0001-first.patch
>   0002-second.patch
>
> which, I think, would be more useful.
That's nice attention to the detail ;-)
Previous: SZEDER GáborNext: Bert Wesarg
Message 5 of 7 in “format-patch: create leading components of output directory”
  1. 1/2 format-patch: create leading components of output directoryBert Wesarg, Oct 5, 2019
  2. 2/2 [RFC] format-patch: configure a command to generate the output directory nameBert Wesarg, Oct 5, 2019
  3. Junio C HamanoOct 6, 2019
  4. SZEDER GáborOct 7, 2019
  5. Junio C HamanoOct 8, 2019
  6. Bert WesargOct 8, 2019
  7. t4014: treat rev-list output as the expected valueDenton Liu, Oct 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.