Re: [PATCH v2 0/2] Make git rebase -r's label generation more resilient
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 18, 2019, 03:42 UTC
- Message-ID
- <xmqq8sod3l5a.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <pull.327.v2.git.1574032570.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 16 quoted lines
> Those labels must be valid ref names, and therefore valid file names. The > initial patch came in via Git for Windows. > > Change since v1: > > * moved the entire sanitizing logic to label_oid(), as a preparatory step. > > Johannes Schindelin (1): > rebase-merges: move labels' whitespace mangling into `label_oid()` > > Matthew Rogers (1): > rebase -r: let `label` generate safer labels > > sequencer.c | 72 +++++++++++++++++++++++++--------------- > t/t3430-rebase-merges.sh | 6 ++++ > 2 files changed, 51 insertions(+), 27 deletions(-)
I think Dscho meant to Cc you as these two patches are meant to be a more complete solution to supersede your [*1*].
[Reference]
*1* <860dee65f49ea7eacf5a0c7c8ffe59095a51b1ce.1573205699.git.congdanhqx@gmail.com>