git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/8] t1300: modernize part of script

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 21, 2019, 04:54 UTC
Message-ID
<xmqq8so9akx5.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<37e2b121d5946cfacb3fc4d2721770e496f7b752.1573670565.git.martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 15 quoted lines
> Create `.git/config` and `expect` files inside `test_expect_success`,
> either inside the one existing test that uses the file, or in a new
> "setup" step before several tests that use it.
>
> Redirect using `>output` rather than `> output`. Use `<<-\EOF" with
> heredocs rather than just `<< EOF` and use `q_to_tab` to create properly
> indented input and output files.
>
> This commit does not modernize the whole script, but just some of it,
> around the point where a later commit will add new content.
>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
>  t/t1300-config.sh | 138 ++++++++++++++++++++++------------------------
>  1 file changed, 65 insertions(+), 73 deletions(-)
Thanks.  All conversions looked OK.
Previous: Martin ÅgrenNext: Martin Ågren
Message 4 of 23 in “builtin/config: canonicalize "value_regex" with `--type=bool[-or-int]`”
  1. 0/8 builtin/config: canonicalize "value_regex" with `--type=bool[-or-int]`Martin Ågren, Nov 13, 2019
  2. 1/8 config: make `git_parse_maybe_bool_text()` publicMartin Ågren, Nov 13, 2019
  3. 2/8 t1300: modernize part of scriptMartin Ågren, Nov 13, 2019
  4. Junio C HamanoNov 21, 2019
  5. 3/8 builtin/config: extract `handle_value_regex()` from `get_value()`Martin Ågren, Nov 13, 2019
  6. Junio C HamanoNov 21, 2019
  7. Martin ÅgrenNov 21, 2019
  8. 4/8 builtin/config: collect "value_regexp" data in a structMartin Ågren, Nov 13, 2019
  9. Junio C HamanoNov 21, 2019
  10. Martin ÅgrenNov 21, 2019
  11. Junio C HamanoNov 22, 2019
  12. 5/8 builtin/config: canonicalize "value_regex" with `--type=bool`Martin Ågren, Nov 13, 2019
  13. Junio C HamanoNov 21, 2019
  14. 6/8 builtin/config: canonicalize "value_regex" with `--type=bool-or-int`Martin Ågren, Nov 13, 2019
  15. 7/8 builtin/config: warn if "value_regex" doesn't canonicalize as booleanMartin Ågren, Nov 13, 2019
  16. Junio C HamanoNov 21, 2019
  17. Martin ÅgrenNov 21, 2019
  18. 8/8 builtin/config: die if "value_regex" doesn't canonicalize as booleanMartin Ågren, Nov 13, 2019
  19. Junio C HamanoNov 14, 2019
  20. Martin ÅgrenNov 14, 2019
  21. Jeff KingNov 14, 2019
  22. Martin ÅgrenNov 14, 2019
  23. Jeff KingNov 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.