Re: [git 2.26] stat counts reported by commit and log are different

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 9, 2020, 22:55 UTC
Message-ID: <xmqq8sj4mfq5.fsf@gitster.c.googlers.com>
In-Reply-To: <20200409224747.GA4173825@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> It might make sense to do so (and/or to make it possible to enable it by
> config like we did for years with diff.renames). But it definitely is
> way more expensive.
> ...
> So not quite as bad percentage-wise, but still pretty expensive. And for
> not a huge benefit. There are ~261 impacted commits. You can see a
> recent example with:
>
>   git show -B -M --stat --summary ce6521e44
>
> where we find that most of builtin/fmt-merge-msg.c was moved to
> fmt-merge-msg.c. It's nice, but it's expensive enough that it probably
> shouldn't be the default.

Not only that, it can cost correctness-wise.  Until this

  https://public-inbox.org/git/xmqqegqaahnh.fsf@gitster.dls.corp.google.com/

gets corrected, it is not advisable to enable -B and -M at the same time.