Re: [PATCH] revision: reallocate TOPO_WALK object flags

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 24, 2020, 16:06 UTC
Message-ID: <xmqq8sgc8n3v.fsf@gitster.c.googlers.com>
In-Reply-To: <8e5b6b9f-a778-7b20-2c67-2d5d8ff0d8a0@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 7 quoted lines

>> @@ -79,7 +79,7 @@ struct object_array {
>>   * builtin/show-branch.c:    0-------------------------------------------26
>
> The only collision is here in builtin/show-branch.c, and when I added
> the TOPO_WALK_* bits, I didn't understand that these bits were
> sufficiently independent from the topo-walk logic that we could add
> collisions here.

The show-branch subcommand does its own walking without using any of the usual revision machinery, and uses a bit per starting point (so the number of starting points is limited by the wordsize), so it should be safe.

It would be wonderful if the bits used by it can be moved to a slab so that it can work from more starting points, or deprecate the subcommand altogether. With better visualization tools (including "log --graph --oneline"), I suspect that it outlived its usefulness.