Re: [PATCH v3] help.c: configurable suggestions

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2020, 17:46 UTC
Message-ID: <xmqq8say36e5.fsf@gitster.c.googlers.com>
In-Reply-To: <C76K6Q09ATLR.1OI5KW390LKFX@taiga>

"Drew DeVault" <sir@cmpwn.com> writes:

Show 10 quoted lines

> On Wed Nov 18, 2020 at 12:16 PM EST, Junio C Hamano wrote:
>> It is unclear from this description alone why this is needed. The
>> seller of this change needs to emphasize how this is better than
>> setting the variable to "0" (do not autocorrect). My guess is that
>> some users do not even need the suggestion of correct spelling when
>> they made a typo?
>
> This is one reason. Another is that spell checking can be
> computationally expensive, and take an annoyingly long time on low-end
> devices.

Both are good reasons to describe in the log message, so that the next reader of "git log" won't have to ask "why?"