Re: [PATCH] doc: mention Python 3.x supports

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2020, 21:06 UTC
Message-ID: <xmqq8s9y93tj.fsf@gitster.c.googlers.com>
In-Reply-To: <CABvFv3JjipUqchLAhyvMax=s4z3VhPyKvSAPqtbj3W4pNOmzvg@mail.gmail.com>

Yang Zhao <yang.zhao@skyboxlabs.com> writes:

Show 7 quoted lines

> Caveat: I am relying on memory here. I haven't looked at this code
> since my last round of PRs...
>
> Yes, git-p4 use the p4 executable, and not an integration library. p4
> has a "serialize for Python" mode which outputs in a python2.7 pickled
> format, which is still supported by python3, and this is what is used
> to receive data from the app.

Ah, OK, the mention of "not 3.x" referred to the fact that its pickle output format is native to 2.7, but 3.x can be made to read it (and that is how we can run with 3.x). That makes sense.

Show 15 quoted lines

>> Not related, but Perforce's official Python bindings supports Python 3
>> from at least 2013 [p4r13]. And they still maintain in [PyPI].
>> That binding requires compiling with Python Development files, though.
>
> Compilation from source is only required on the latest version of
> python3. p4python has wheels on PyPI, but it's consistently a minor
> version behind. At the moment wheels for 3.8 exist for all major
> platforms, but not 3.9.
>
>> > The change to INSTALL just drops the mention of 3.x; do we want to
>> > specifically say that any version of 3.x is OK, or is it generally
>> > accepted that Python 3.x is "later" than "Python 2.7"?
>
> Any 3.x is OK, as long as we are staying with interfacing with the p4
> executable directly.

It makes it a lot simpler that we do not have to say anything. So the patch under discussion is good as-is without any tweaks, then.

Thanks.