Re: [PATCH 1/2] test-lib: show missing prereq summary
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 15, 2021, 17:53 UTC
- Message-ID
- <xmqq8rxpfgqh.fsf@gitster.g>
- In-Reply-To
- <211115.865ysts45o.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 10 quoted lines
>> +if test -n "$missing_prereq" >> +then >> + unique_missing_prereq=$( >> + echo $missing_prereq | >> + tr -s "," "\n" | >> + grep -v '^$' | >> + sort -u | >> + paste -s -d ',') > > What is paste? Some out-of-tree debugging utility?
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/paste.html
Don't feel bad for not knowing it. I usually do not use cut or paste myself and I had to look it up the other day while reviewing the RFC phase of this series.
I am not sure '\n' is a good idea from portability perspective. I thought I wrote '\012' in the illustration in my review?