Re: [RFC PATCH 1/1] mv: integrate with sparse-index

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 15, 2022, 17:23 UTC
Message-ID: <xmqq8rtbf7uz.fsf@gitster.g>
In-Reply-To: <20220315100145.214054-2-shaoxuan.yuan02@gmail.com>

Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> writes:

Show 17 quoted lines

> Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
> ---
>  builtin/mv.c                             |  3 +++
>  t/t1092-sparse-checkout-compatibility.sh | 34 ++++++++++++++++++++++++
>  2 files changed, 37 insertions(+)
>
> diff --git a/builtin/mv.c b/builtin/mv.c
> index 83a465ba83..111360ebf5 100644
> --- a/builtin/mv.c
> +++ b/builtin/mv.c
> @@ -138,6 +138,9 @@ int cmd_mv(int argc, const char **argv, const char *prefix)
>  
>  	git_config(git_default_config, NULL);
>  
> +	prepare_repo_settings(the_repository);
> +	the_repository->settings.command_requires_full_index = 0;
> +

The command used to be marked as one of the commands that require full index to work correctly. Why did it suddenly become not to require it, especially without any other changes to make it so?

This patch needs a lot more explaining to do in itse proposed log message.

Thanks.