Re: [PATCH] http: support building on RHEL6

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 5, 2022, 17:46 UTC
Message-ID: <xmqq8rp7laez.fsf@gitster.g>
In-Reply-To: <220704.867d4tb8oo.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 14 quoted lines

>>> But I do not think the patch text, what the patch does, is that bad.
>>> We advertise in INSTALL that you need 7.19.4 to build without NO_CURL;
>>
>>> IOW, you should be able to build Git with 7.21.3 or later.
>>
>> That conclusion is nonsense.  "with a version before 7.21.3 as long
>> as it is newer than 7.19.4" is what I should have said.
>
> I find this line of argument to be circular legalese without a
> distinction.
>
> As 644de29e220 (http: drop support for curl < 7.19.4, 2021-07-30) notes
> (which I submitted as part of the git-curl-compat.h series) the reason
> we have 7.19.4 as a cut-off is entirely due to RHEL.

Ah, I didn't dig deep enough.

On that backdrop, it becomes a reasonable alternative change to bump the minimum required version to 7.21.3 with something like the "I wonder if the attached patch is worth considering" patch I sent in the upthread, without adding the conditional based on GIT_CURL_HAVE_CURLOPT_RESOLVE cpp macro.

We could pick an even later cut-off point, but that requires a separate discussion.

Thanks.