Re: [PATCH v2 3/4] rebase: stop accepting --rebase-merges=""

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2023, 23:08 UTC
Message-ID: <xmqq8rgpcn8l.fsf@gitster.g>
In-Reply-To: <f0d0a3fb-d7eb-84d6-7852-0d30eb38af63@dunelm.org.uk>

Phillip Wood <phillip.wood123@gmail.com> writes:

> The usual way we handle that is to set the value of rebase_merges from
> the config before calling parse_options(). However your solution is
> fine.

Is it? If it is not too much to ask, I'd prefer to have code that does not surprise people, and "the usual way" you mentioned is what readers around here expect to see. I didn't check and think about the patch in quetion, and especially the existing code that the patch needs to touch, too deeply, so if it is too convoluted already that it would be a lot of work to make it work in "the usual way", it may be OK, but otherwise, the solution may not be fine.

Thanks.