Re: [PATCH v3 0/2] diff: copies-harder support

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2024, 15:36 UTC
Message-ID: <xmqq8r09u5u5.fsf@gitster.g>
In-Reply-To: <8734qihft5.fsf@gentoo.org>

Sam James <sam@gentoo.org> writes:

Show 12 quoted lines

> ping - let me know if I need to do anything different. Thanks!
>
>>>
>>>
>>>>  Documentation/config/diff.txt   |  8 +++++---
>>>>  Documentation/config/status.txt |  4 +++-
>>>>  diff.c                          | 14 +++++++++++---
>>>>  diff.h                          |  1 +
>>>>  diffcore-rename.c               |  6 ++++--
>>>>  merge-ort.c                     |  2 +-
>>>>  merge-recursive.c               |  2 +-
>>>>  7 files changed, 26 insertions(+), 11 deletions(-)

Copies-harder is supported from the command line already. We do not want a configuration variable for it. diff.renames configuration was already a mistake enough. Let's not pile on a new mistake on an old mistake that it is too late for us to take back.

Thanks.