Re: [PATCH 5/8] pack-bitmap-write.c: select pseudo-merges even for small bitmaps

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2024, 16:42 UTC
Message-ID: <xmqq8qwvhzja.fsf@gitster.g>
In-Reply-To: <20240817103401.GB551779@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

>> Select pseudo-merges even for bitmaps with fewer than 100 commits to
>> make such testing easier. In practice, this should not make a difference
>> to non-testing bitmaps, as they are unlikely to be used when a
>> repository has so few commits to begin with.
>
> I think you could argue that if there are fewer than 100 commits in the
> history that pseudo-merge bitmaps are overkill, so it does not matter
> much either way. But I think being consistent with our behavior (i.e.,
> generating them if asked) is important for testing and debugging.

OK. I had an opposite reaction to this change, i.e. "eh, are we lifting the safety that protected the users from asking for a suboptimal way to pack, only to make it easier to write this test?", but I do buy "the user tells us to do the suboptimal thing, we do that thing."