Re: [PATCH (v2.47 regression)] hash.h: set NEEDS_CLONE_HELPER_UNSAFE in fallback mode

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2024, 18:20 UTC
Message-ID: <xmqq8qv5hwv0.fsf@gitster.g>
In-Reply-To: <Zv3r9FBd+Nog3wb7@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 18 quoted lines

> On Wed, Oct 02, 2024 at 07:26:18PM -0400, Jeff King wrote:
>> diff --git a/hash.h b/hash.h
>> index f97f858307..756166ce5e 100644
>> --- a/hash.h
>> +++ b/hash.h
>> @@ -82,6 +82,9 @@
>>  #  ifdef platform_SHA1_Clone
>>  #    define platform_SHA1_Clone_unsafe platform_SHA1_Clone
>>  #  endif
>> +#  ifdef SHA1_NEEDS_CLONE_HELPER
>> +#    define SHA1_NEEDS_CLONE_HELPER_UNSAFE
>> +#  endif
>>  #endif
>
> Gah. I could have sworn I wrote something like this myself, but I must
> have dropped it or hallucinated writing it in the first place.
>
> Thanks for finding and fixing.

Yeah, thanks, all.