Re: [PATCH 1/2] midx: show progress during QSORT operation

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2025, 16:29 UTC
Message-ID: <xmqq8qqc30o0.fsf@gitster.g>
In-Reply-To: <CAE7as+YPKuBd+ztBerim6e1kZXZwUHdb_qjcMfZSBa4LkiyJow@mail.gmail.com>

Ayush Chandekar <ayu.chandekar@gmail.com> writes:

Show 7 quoted lines

>> Hmph.  If the implementation is correct (which I cannot tell), this
>> needs to explain why it is a bit better than saying nothing.
> While going through the code, I noticed the TODO comment: "Measure
> QSORT() progress", and I thought it might be interesting to explore.
> For big codebases, being stuck at zero would make it feel like there's
> no progress happening and that is why putting a progress might be
> better.

That much I already know---otherwise we would not have that comment there ;-)

What I meant was that the proposed log message did not give readers any hint how the implementation given in the patch is correct, the assumption it makes on the behaviour of sort(3), etc.