Re: issue with git submodules and a clone.defaultRemoteName different than origin?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 6, 2025, 23:32 UTC
- Message-ID
- <xmqq8qm41m62.fsf@gitster.g>
- In-Reply-To
- <bdf7e50f-aa65-4514-b147-9f7ebed147ab@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 7 quoted lines
> It looks like those end up in the "read_remotes_file" and > "read_branches_file" functions which are deprecated, and planned to be > removed in 3.0... > > Would patches to modify those to take a repository pointer in order to > allow callers of read_config() to work properly with a submodule > repository be acceptable?
The recent trend has been that it generally is very much welcomed to fix such a code path that takes "repo" at an entry point but ends up deep in its callchain to ignore it and use the_repository instead, even without a potential use case to benefit from such a change.
You have a concrete use case, so I would suspect it is even better than "acceptable". Patrick, what do you think?
Thanks.