Re: [PATCH] Add grep.fullName config variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 17, 2014, 22:21 UTC
- Message-ID
- <xmqq7g7sbh56.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <874n2w3abu.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
> This configuration variable sets the default for the --full-name option. > > Signed-off-by: Andreas Schwab <schwab@linux-m68k.org> > ---
Would this change break Porcelains (e.g. Emacs modes) and force them to be updated to explicitly pass --no-full-name to unbreak them?
Show 36 quoted lines
> Documentation/git-grep.txt | 3 +++
> grep.c | 5 +++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index f837334..31811f1 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -53,6 +53,9 @@ grep.extendedRegexp::
> option is ignored when the 'grep.patternType' option is set to a value
> other than 'default'.
>
> +grep.fullName::
> + If set to true, enable '--full-name' option by default.
> +
>
> OPTIONS
> -------
> diff --git a/grep.c b/grep.c
> index c668034..ece04bf 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -86,6 +86,11 @@ int grep_config(const char *var, const char *value, void *cb)
> return 0;
> }
>
> + if (!strcmp(var, "grep.fullname")) {
> + opt->relative = !git_config_bool(var, value);
> + return 0;
> + }
> +
> if (!strcmp(var, "color.grep"))
> opt->color = git_config_colorbool(var, value);
> else if (!strcmp(var, "color.grep.context"))
> --
> 1.9.0