Re: [PATCH v2] git-rebase: Teach rebase "-" shorthand.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 19, 2014, 21:02 UTC
- Message-ID
- <xmqq7g7p3nrl.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140319195503.GD11018@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
Show 18 quoted lines
>> I thought your suggestion was:
>>
>> 'rebase @{-1}' says 'Fast-fowarded HEAD to @{-1}'. It should say
>> 'Fast-forwarded HEAD to 4f407407 (rebase: allow "-" short-hand
>> for the previous branch, 2014-03-19)' instead.
>>
>> Or it could be:
>>
>> 'rebase @{-1}' says 'Fast-fowarded HEAD to @{-1}'. It should say
>> 'Fast-forwarded HEAD to master' instead.
>>
>> In either case, it does not look like such a change is about
>> teaching "-" as a synonym to "@{-1}".
>
> My suggestion was specifically:
>
> 'rebase -' says 'Fast-forwarded HEAD to -'. It should say
> 'Fast-forwarded HEAD to master' instead.OK, it was closer to the latter.
But why is it OK to leave @{-1}, which is just as "hmm, I do not remember what the previous branch was myself" when the user says "@{-1}" in the output while it not OK to leave "-" in the output?
I do not think of any sane reason, and that is why I think this improvement is not part of "teaching rebase that '-' can be used in place of @{-1}" topic.