git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "trace.c", line 219: error: identifier redeclared: trace_strbuf

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 8, 2014, 18:11 UTC
Message-ID
<xmqq7g1enfs6.fsf@gitster.dls.corp.google.com>
In-Reply-To
<540B742F.5030700@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 25 quoted lines
> The issue was introduced with e05bed96 (trace: add 'file:line' to all
> trace output).
>
> -- >8 --
> Subject: [PATCH] trace: correct trace_strbuf() parameter type for !HAVE_VARIADIC_MACROS
>
> Reported-by: dev <dev@cor0.com>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace.c b/trace.c
> index 54aaee5..b6f25a2 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -216,7 +216,7 @@ void trace_argv_printf(const char **argv, const char *format, ...)
>  	va_end(ap);
>  }
>  
> -void trace_strbuf(const char *key, const struct strbuf *data)
> +void trace_strbuf(struct trace_key *key, const struct strbuf *data)
>  {
>  	trace_strbuf_fl(NULL, 0, key, data);
>  }
Thanks.
Will queue on top of kb/perf-trace, hoping to merge it down later.
Previous: dev
Message 4 of 4 in “"trace.c", line 219: error: identifier redeclared: trace_strbuf”
  1. devSep 6, 2014
  2. René ScharfeSep 6, 2014
  3. devSep 7, 2014
  4. Junio C HamanoSep 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.