git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] builtin: move builtin retrieval to get_builtin()

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2014, 16:42 UTC
Message-ID
<xmqq7fytzslf.fsf@gitster.dls.corp.google.com>
In-Reply-To
<54693454.1040704@inventati.org>
Slavomir Vlcek <svlc@inventati.org> writes:
> I noticed that the patch has been modified (suggested 'static'
> scope modification, commit message) and added to the 'next'
> branch. So does this mean my task is done [...]?

Even after the change hits 'next', other people may still find problems and rooms for improvements that you and those who reviewed the patch missed, and you may have to respond with follow-up patches on top. We'll usually give 3 days to a few weeks, depending on the complexity of the change, for that to happen and call it "cooking the patch in 'next'". After that the change will be merged to 'master' so that it can appear in the next release.

For now, the patch you sent is "done", even though you can still send improvements on top if you want to.

Thanks.
Previous: Slavomir Vlcek
Message 9 of 9 in “builtin: move builtin retrieval to get_builtin()”
  1. builtin: move builtin retrieval to get_builtin()slavomir vlcek, Nov 12, 2014
  2. SubmittingPatches: fix an inconsistencyslavomir vlcek, Nov 13, 2014
  3. Junio C HamanoNov 13, 2014
  4. Junio C HamanoNov 13, 2014
  5. Junio C HamanoNov 13, 2014
  6. slavomir vlcekNov 13, 2014
  7. Junio C HamanoNov 13, 2014
  8. Slavomir VlcekNov 16, 2014
  9. Junio C HamanoNov 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.