Re: [PATCH 2/2] git-send-email: add --transfer-encoding option

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2014, 23:37 UTC
Message-ID: <xmqq7fyisvgj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cQ_jm1W3n7KqrRihuj7ie=wGTRMupyAnfLHXqFAAnhv4Q@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 24 quoted lines

>> +test_expect_success $PREREQ 'sendemail.transferencoding=7bit fails on 8bit data' '
>> +       clean_fake_sendmail &&
>> +       git config sendemail.transferEncoding 7bit &&
>
> test_config here and elsewhere perhaps?
> ...
>
>> +       test_must_fail git send-email \
>> +         --transfer-encoding=7bit \
>
> Redundant 7bit request.
>
>> +         --smtp-server="$(pwd)/fake.sendmail" \
>> +         email-using-8bit \
>> +         2>errors >out &&
>> +       grep "cannot send message as 7bit" errors &&
>> +       test -z "$(ls msgtxt*)"
>> +'
>> +
>> +test_expect_success $PREREQ '--transfer-encoding overrides sendemail.transferEncoding' '
>> +       clean_fake_sendmail &&
>> +       git config sendemail.transferEncoding 8bit
>
> Broken &&-chain.

Thanks for a careful reading ;-).

The original before this patch is written in old 2005 style, which makes it rather hard to read and add new tests to mimick the existing tests. Perhaps we would need to clean it up at some point, probably after the dust settles after this series is done.