Re: [PATCH] git.c: remove unused includes

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2015, 19:52 UTC
Message-ID: <xmqq7fwvd95q.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1420798353-12316-1-git-send-email-kuleshovmail@gmail.com>

Alexander Kuleshov <kuleshovmail@gmail.com> writes:

Show 5 quoted lines

> * <cache.h> and <commit.h> already included in <builtin.h>
>
> * <quote.h> was appeared in (6035d6aa GIT_TRACE: show which
> built-in/external commands are executed  25 Jun 2006) and sq_quote_print
> was removed at (82aae5c quote: remove sq_quote_print() Jul 30 2013)

That's not 6035d6aa, though.

We started to include "quote.h" at 575ba9d6 (GIT_TRACE: show which built-in/external commands are executed, 2006-06-25) that wanted to use sq_quote_print().

When 6ce4e61f (Trace into a file or an open fd and refactor tracing code., 2006-09-02) introduced trace.c API, the calls this file makes to sq_quote_print() were replaced by calls to trace_argv_printf() that are declared in "cache.h", which this file already includes. We should have stopped including "quote.h" in that commit, but forgot to do so.

Show 21 quoted lines

>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  git.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/git.c b/git.c
> index 09b3bcf..c9bec99 100644
> --- a/git.c
> +++ b/git.c
> @@ -1,10 +1,7 @@
>  #include "builtin.h"
> -#include "cache.h"
>  #include "exec_cmd.h"
>  #include "help.h"
> -#include "quote.h"
>  #include "run-command.h"
> -#include "commit.h"
>  
>  const char git_usage_string[] =
>  	"git [--version] [--help] [-C <path>] [-c name=value]\n"