git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 6, 2015, 20:05 UTC
Message-ID
<xmqq7fvuhkl3.fsf@gitster.dls.corp.google.com>
In-Reply-To
<28F603A7-610B-4711-9D2F-CD9866C96A74@gmail.com>
"Kyle J. McKay" <mackyle@gmail.com> writes:
Show 7 quoted lines
> Actually I just tested it.  If we #undef it we could end up producing  
> these:
>
>    error: syntax error before DEPRECATED_ATTRIBUTE
>
> So I think it needs to stay #define'd to nothing to be safe in case  
> anything later on ends up including stuff that uses it.

Doesn't the fact that your test failed indicates that it is not jsut "to be safe in case" but is required for correctness?

The first hit for "MAC_OS_X_VERSION_MIN_REQUIRED" was this:
  https://opensource.apple.com/source/CarbonHeaders/CarbonHeaders-18.1/AvailabilityMacros.h

which marks quite a many macros to that value. I do not know what changes they make to openssl/*.h (which is included just after the above header is included, but I would imagine that is where the AVAILABLE_MAC_OS_X_VERSION_XXX_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_VERSION_YYY macros are checked and annoying warnings that are being squelched by the previous change are given?

Previous: Kyle J. McKayNext: Kyle J. McKay
Message 4 of 6 in “git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED”
  1. git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIREDKyle J. McKay, Feb 6, 2015
  2. Eric SunshineFeb 6, 2015
  3. Kyle J. McKayFeb 6, 2015
  4. Junio C HamanoFeb 6, 2015
  5. Kyle J. McKayFeb 6, 2015
  6. Eric SunshineFeb 6, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.