Re: [PATCHv2] Add hint interactive cleaning

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 2, 2015, 19:39 UTC
Message-ID: <xmqq7fuzb344.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1425211105-18873-1-git-send-email-jn.avila@free.fr>

Jean-Noel Avila <jn.avila@free.fr> writes:

Show 21 quoted lines

> For translators, specify that a  y/N reply is needed.
>
> Signed-off-by: Jean-Noel Avila <jn.avila@free.fr>
> ---
>  builtin/clean.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 7e7fdcf..98c103f 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -754,7 +754,8 @@ static int ask_each_cmd(void)
>  		/* Ctrl-D should stop removing files */
>  		if (!eof) {
>  			qname = quote_path_relative(item->string, NULL, &buf);
> -			printf(_("remove %s? "), qname);
> +			/* TRANSLATORS: Make sure to keep [y/N] as is */
> +			printf(_("Remove %s [y/N]? "), qname);
>  			if (strbuf_getline(&confirm, stdin, '\n') != EOF) {
>  				strbuf_trim(&confirm);
>  			} else {

Thanks. All other interactive prompts from this command (i.e. menu_opts.prompt) seem to capitalize their first word, so upcasing this message is a good change, too.