git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer.c: abbreviate hashs placed in the middle of messages

From
Junio C Hamano <gitster@pobox.com>
Date
May 8, 2015, 17:31 UTC
Message-ID
<xmqq7fsjm0wb.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAN0XMOLhkTMWDr+eOsb5H8YiC1b7Nk0OKTSfi02ocr1unwFjfw@mail.gmail.com>
Ralf Thielow <ralf.thielow@gmail.com> writes:
>>         error(_("-m option was given for non-merge commit '%s'", ...);
>
> The %s can be placed to somewhere else in translations.

That is true for all the messages, and is something the l10n people need to be aware of.

We've seen those who are careful to keep '%s' for longer strings (e.g. end-user controlled ones strings) at the end for this exact reason. I do not offhand recall if there were cases where we committed one version that had %s in the middle and then fixed later to change that message in a separate commit, but there were cases where earlier messages with %s in the middle were fixed for this exact reason in their rerolls.

Previous: Ralf ThielowNext: Ralf Thielow
Message 6 of 14 in “sequencer.c: abbreviate hashs placed in the middle of messages”
  1. sequencer.c: abbreviate hashs placed in the middle of messagesRalf Thielow, May 8, 2015
  2. Eric SunshineMay 8, 2015
  3. Ralf ThielowMay 8, 2015
  4. Junio C HamanoMay 8, 2015
  5. Ralf ThielowMay 8, 2015
  6. Junio C HamanoMay 8, 2015
  7. Ralf ThielowMay 8, 2015
  8. Junio C HamanoMay 8, 2015
  9. Ralf ThielowMay 8, 2015
  10. Junio C HamanoMay 8, 2015
  11. Ralf ThielowMay 8, 2015
  12. Matthieu MoyMay 10, 2015
  13. Junio C HamanoMay 10, 2015
  14. Matthieu MoyMay 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.