Re: [RFC] Case insensitive URL rewrite

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2015, 18:26 UTC
Message-ID: <xmqq7fkkg7tq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <B207EFC1-48DF-4B8F-8373-28A0CB5660B0@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 5 quoted lines

> What do you think about a flag that makes these rewrites case insensitive? E.g. with the following config flag:
>
> [url "<actual url base>"]
> 	insteadOf = <other url base>
> 	ignorecase = true

I am with Daniel on this.

It is perfectly fine to consider these two equivalent.

    git clone https://github.com/git/git (canonical one)
    git clone https://GitHub.com/git/git (host part in funny case)

In fact, I think we should do this without any additional configuration variable.

On the other hand, these two MUST be treated as different by default:

    git clone https://github.com/GIT/GIT (differences outside host part)
    git clone git@github.com:GIT/GIT     (differences outside host part)

Although I am OK if this is hidden behind a configuration variable, I am not sure how much value you would be giving to the users.

In any case, I expect that additional change (on top of what is required to make hostname part treated case insensitively) would not be too bad, if we were going to fix the hostname part.