git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 07/10] t5100-mailinfo.sh: use the $( ... ) construct for command substitution

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 27, 2015, 23:46 UTC
Message-ID
<xmqq7fjzbgkr.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<5679B3E2.7090406@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 15 quoted lines
> Am 22.12.2015 um 19:35 schrieb Johannes Sixt:
>> Am 22.12.2015 um 16:27 schrieb Elia Pinto:
>>> -for mail in `echo 00*`
>>> +for mail in $(echo 00*)
>>
>>> -for mail in `echo rfc2047/00*`
>>> +for mail in $(echo rfc2047/00*)
>>
>> True, these are equvalence transformations. But a better way to get rid
>> of the back-quotes is to write these lines as
>>
>> for mail in echo 00*
>> for mail in echo rfc2047/00*
>
> Ahem... both of these lines without the 'echo', of course!

Very true. Let's leave that kind of things as separate clean-ups after these patches settle, as mixing manual and mechanical changes in a single patch makes it harder to review.

Thanks.
Previous: Johannes SixtNext: Junio C Hamano
Message 11 of 16 in “use the $( ... ) construct for command substitution”
  1. 00/10 use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  2. 01/10 t3101-ls-tree-dirname.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  3. 02/10 t3210-pack-refs.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  4. 03/10 t3403-rebase-skip.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  5. 04/10 t3511-cherry-pick-x.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  6. 05/10 t3600-rm.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  7. 06/10 t3700-add.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  8. 07/10 t5100-mailinfo.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  9. Johannes SixtDec 22, 2015
  10. Johannes SixtDec 22, 2015
  11. Junio C HamanoDec 27, 2015
  12. Junio C HamanoDec 28, 2015
  13. Johannes SixtDec 28, 2015
  14. 08/10 t5300-pack-object.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  15. 09/10 t5301-sliding-window.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015
  16. 10/10 t5302-pack-index.sh: use the $( ... ) construct for command substitutionElia Pinto, Dec 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.