Re: [PATCH] Disown ssh+git and git+ssh

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2016, 21:10 UTC
Message-ID: <xmqq7fi8s4dx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1455289777-186690-1-git-send-email-cmn@dwim.me>

Carlos Martín Nieto <cmn@dwim.me> writes:

Show 8 quoted lines

> These were silly from the beginning, but we have to support them for
> compatibility. That doesn't mean we have to show them in the
> documentation. These were already left out of the main list, but a
> reference in the main manpage was left, so remove that.
>
> Also add a note to discourage their use if anybody goes looking for them
> in the source code.
> ---

Sign off?

Show 30 quoted lines

>  Documentation/git.txt | 2 +-
>  connect.c             | 4 ++++
>  transport.c           | 4 ++++
>  3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index d987ad2..2f90635 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -1122,7 +1122,7 @@ of clones and fetches.
>  	    connection (or proxy, if configured)
>  
>  	  - `ssh`: git over ssh (including `host:path` syntax,
> -	    `git+ssh://`, etc).
> +	    `ssh://`, etc).
>  
>  	  - `rsync`: git over rsync
>  
> diff --git a/connect.c b/connect.c
> index fd7ffe1..4f96424 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -267,6 +267,10 @@ static enum protocol get_protocol(const char *name)
>  		return PROTO_SSH;
>  	if (!strcmp(name, "git"))
>  		return PROTO_GIT;
> +	/*
> +	 * These ssh schemes remain supported for compat but are
> +	 * undocumented and their use is discouraged
> +	 */

Micronit.

It is not like we continue to support two more different protocols; we just allow users to spell the thing in different ways.

"These ssh schemes" might be clearer if spelled "These alternative ways to spell the ssh scheme".

Show 7 quoted lines

>  		|| starts_with(url, "file://")
>  		|| starts_with(url, "git://")
>  		|| starts_with(url, "ssh://")
> +		/*
> +		 * These ssh schemes remain supported for compat but are
> +		 * undocumented and their use is discouraged
> +		 */

Likewise.

>  		|| starts_with(url, "git+ssh://")
>  		|| starts_with(url, "ssh+git://")) {
>  		/*

Thanks.