Re: [RFC PATCH] pathspec: get non matching arguments without reporting.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 5, 2016, 23:11 UTC
- Message-ID
- <xmqq7ff885hj.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1462489197-30616-1-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 7 quoted lines
> When giving more than just pathspec arguments (e.g. submodule labels), > we need a way to check all non-matching arguments for the pathspec parsing > if these are the submodule labels or typos. > > This patch prepares for that use case by splitting up `report_path_error` > into a new checking function `unmatched_pathspec_items` and a > reporting callback.
I seem to recall that there is a longstanding plan to move the "seen[]" array that is separate and outside from the pathspec structure into the pathspec structure. Wouldn't that be a more sensible approach to solve the same thing?