Re: [PATCH v2 2/3] mailsplit: support unescaping mboxrd messages
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 6, 2016, 18:24 UTC
- Message-ID
- <xmqq7fe2xjii.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160605044641.9221-3-e@80x24.org>
Eric Wong <e@80x24.org> writes:
Show 37 quoted lines
> This will allow us to parse the output of --pretty=mboxrd > and the output of other mboxrd generators. > > Signed-off-by: Eric Wong <e@80x24.org> > --- > Documentation/git-mailsplit.txt | 7 ++++++- > builtin/mailsplit.c | 18 ++++++++++++++++++ > t/t5100-mailinfo.sh | 31 +++++++++++++++++++++++++++++++ > t/t5100/0001mboxrd | 4 ++++ > t/t5100/0002mboxrd | 5 +++++ > t/t5100/sample.mboxrd | 19 +++++++++++++++++++ > 6 files changed, 83 insertions(+), 1 deletion(-) > create mode 100644 t/t5100/0001mboxrd > create mode 100644 t/t5100/0002mboxrd > create mode 100644 t/t5100/sample.mboxrd > > diff --git a/Documentation/git-mailsplit.txt b/Documentation/git-mailsplit.txt > index 4d1b871..e3b2a88 100644 > --- a/Documentation/git-mailsplit.txt > +++ b/Documentation/git-mailsplit.txt > @@ -8,7 +8,8 @@ git-mailsplit - Simple UNIX mbox splitter program > SYNOPSIS > -------- > [verse] > -'git mailsplit' [-b] [-f<nn>] [-d<prec>] [--keep-cr] -o<directory> [--] [(<mbox>|<Maildir>)...] > +'git mailsplit' [-b] [-f<nn>] [-d<prec>] [--keep-cr] [--mboxrd] > + -o<directory> [--] [(<mbox>|<Maildir>)...] > > DESCRIPTION > ----------- > @@ -47,6 +48,10 @@ OPTIONS > --keep-cr:: > Do not remove `\r` from lines ending with `\r\n`. > > +--mboxrd:: > + Input is of the "mboxrd" format and "^>+From " line escaping is > + reversed.
This just makes me wonder if there is a practical reason why people would not want this always enabled. I just looked at output from
$ git log --grep='>>*From '
in the kernel repository, and I saw no cases where the committer really wanted to preserve the leading one or more '>' on that line. No, I didn't go through all of 150+ such commits, but I did check the couple dozen of them from the recent history.
Our history also have 5 instances of them, none of which should have had the leading '>' if the committer were careful.
Show 12 quoted lines
> diff --git a/t/t5100/sample.mboxrd b/t/t5100/sample.mboxrd > new file mode 100644 > index 0000000..79ad5ae > --- /dev/null > +++ b/t/t5100/sample.mboxrd > @@ -0,0 +1,19 @@ > +From mboxrd Mon Sep 17 00:00:00 2001 > +From: mboxrd writer <mboxrd@example.com> > +Date: Fri, 9 Jun 2006 00:44:16 -0700 > +Subject: [PATCH] a commit with escaped From lines > + > +>From the beginning, mbox should have been mboxrd
Indeed ;-)