Re: git add -p with new file

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 13, 2016, 18:48 UTC
Message-ID: <xmqq7f734qe0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161213173341.wemlunlixdp6277h@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

>> I am also not really sure what problem this feature is trying to solve.
>> If the "problem"(?) is that it should act more like "git add" instead of
>> "git add -u", for whatever reason, this may be fine (but the
>> configuration option is a must-have then).
>
> I think the problem is just that "add -p" does not give the whole story
> of what you might want to do before making a commit.

The same is shared by "git diff [HEAD]", by the way. It is beyond me why people use "add -p", not "git diff [HEAD]", for the final sanity check before committing.

Perhaps the latter is not advertised well enough? "add -p" does not even page so it is not very useful way to check what is being added if you are adding a new file (unless you are doing a toy example to add a 7-line file).

Show 7 quoted lines

>> > I'd also probably add interactive.showUntracked to make the whole thing
>> > optional (but I think it would be OK to default it to on).
>> Hm, "interactive.showUntracked" is a confusing name because "git add -i"
>> (interactive) already handles untracked files.
>
> Sure, that was just meant for illustration. I agree there's probably a
> better name.

"interactive.*" is not a sensible hierarchy to use, because things other than "add" can go interactive.

addPatch.showUntracked?