Re: [PATCH] push options: fail properly in the stateless case

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2017, 23:01 UTC
Message-ID: <xmqq7f50uw0q.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kaszczpnu+VEV3y+61qgji-0+vRFVLk8Q1+BbSDgiHz1Q@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

>>> +'option push-option <c-string>::
>>> +     Transmit this push option.
>>> +
>>
>> There is no "c-string" in the current documentation used or
>> defined.  The closest thing I found is
>>
>>     ... that field will be quoted in the manner of a C string ...
>>
>> in git-status page, but I do not think you send the value for an
>> push-option after running quote_c_style(), so I am puzzled.
>
> When implementing push options, we discussed that and according to
> Documentation/git-push:
>
>     The given string must not contain a NUL or LF character.

OK, so "Transmit <string> as a push option" is sufficient, as the string is sent as-is. OK.

Thanks.