Re: [RFC PATCH v2 00/22] Add blame to libgit

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2017, 09:24 UTC
Message-ID: <xmqq7f1iv5fn.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170514031513.9042-1-whydoubt@gmail.com>

Jeff Smith <whydoubt@gmail.com> writes:

> Rather than duplicate large portions of builtin/blame.c in cgit, it
> would be better to shift its core functionality into libgit.a.  The
> functionality left in builtin/blame.c mostly relates to terminal
> presentation.

As I said in my review of 04/22, it is a bit hard/tedious to sift the changes to refactoring that actually changes code and pure renaming and movement of lines across files with the current sequence of the series, so it is very possible that I may have missed something, but from a cursory read through the series, from the comparison between master and the result of applying all patches, and inspection of the resulting builtin/blame.c file, I think what this series does is very sensible in general. blame.h does not seem to expose anything that is not needed, which is a good sign.