Re: [PATCHv3] tag: add --edit option

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 7, 2018, 20:47 UTC
Message-ID: <xmqq7ero7cjd.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cQ=Uvp5k7NprzqU1Cfi1b0jj5T63Nxzqg+O5ucinD9fmQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 34 quoted lines

> On Tue, Feb 6, 2018 at 3:36 AM, Nicolas Morey-Chaisemartin
> <nmoreychaisemartin@suse.com> wrote:
>> Add a --edit option whichs allows modifying the messages provided by -m or -F,
>> the same way git commit --edit does.
>>
>> Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
>> ---
>> Changes since v2 ( https://public-inbox.org/git/e99947cf-93ba-9376-f059-7f6a369d3ad5@suse.com ):
>>  * Add [-e] to git tag summary
>
> Thanks, I think this addresses all my comments from previous rounds.
> Just a couple minor style issues below...
>
>> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
>> @@ -452,6 +452,21 @@ test_expect_success \
>> +> +test_expect_success \
>> +       'creating an annotated tag with -m message --edit should succeed' '
>> +       EDITOR=./fakeeditor     git tag -m "A message" --edit annotated-tag-edit &&
>
> Whitespace between 'fakeeditor' and 'git' is a tab but should be a space.
>
>> +       get_tag_msg annotated-tag-edit >actual &&
>> +       test_cmp expect actual
>> +'
>> @@ -465,6 +480,21 @@ test_expect_success \
>> +test_expect_success \
>> +       'creating an annotated tag with -F messagefile --edit should succeed' '
>> +       EDITOR=./fakeeditor     git tag -F msgfile --edit file-annotated-tag-edit &&
>
> Ditto.
>
>> +       get_tag_msg file-annotated-tag-edit >actual &&
>> +       test_cmp expect actual
>> +'

Also, GIT_EDITOR takes precedence over EDITOR, so these two new tests should use it instead, just like other existing tests do.

Will try to amend locally before queuing, so unless I botch that (or others find other things to tweak), no need to re-send.

Thanks, both.