Re: [PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 14, 2018, 18:28 UTC
Message-ID: <xmqq7erfo287.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180214154130.111708-1-benpeart@microsoft.com>

Ben Peart <benpeart@microsoft.com> writes:

Show 5 quoted lines

> Remove the reference to setting core.fsmonitor to `true` (or `false`) as those
> are not valid settings.
>
> Signed-off-by: Ben Peart <benpeart@microsoft.com>
> ---

Thanks. It is a bit embarrassing that nobody caught it for this long. Will apply.

Show 26 quoted lines

>
> Notes:
>     Base Ref: master
>     Web-Diff: https://github.com/benpeart/git/commit/4b7ec2c11e
>     Checkout: git fetch https://github.com/benpeart/git fsmonitor_docs-v1 && git checkout 4b7ec2c11e
>
>  Documentation/git-update-index.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
> index bdb0342593..ad2383d7ed 100644
> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -484,8 +484,8 @@ the `core.fsmonitor` configuration variable (see
>  linkgit:git-config[1]) than using the `--fsmonitor` option to
>  `git update-index` in each repository, especially if you want to do so
>  across all repositories you use, because you can set the configuration
> -variable to `true` (or `false`) in your `$HOME/.gitconfig` just once
> -and have it affect all repositories you touch.
> +variable in your `$HOME/.gitconfig` just once and have it affect all
> +repositories you touch.
>  
>  When the `core.fsmonitor` configuration variable is changed, the
>  file system monitor is added to or removed from the index the next time
>
> base-commit: e7e80778e705ea3f9332c634781d6d0f8c6eab64