Re: [PATCH v3 3/5] ref-filter: change parsing function error handling

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 19, 2018, 19:41 UTC
Message-ID: <xmqq7eq7von9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <010201623e5944b9-8d44ad36-a6df-4bd3-97e7-de4ee54af3c0-000000@eu-west-1.amazonses.com>

Olga Telezhnaya <olyatelezhnaya@gmail.com> writes:

Show 7 quoted lines

> Continue removing any printing from ref-filter formatting logic,
> so that it could be more general.
>
> Change the signature of parse_ref_filter_atom() by adding
> strbuf parameter for error message.
> Return value means the same except negative values: they indicate
> errors (previous version could return only non-negative value).

"The same" meaning? The same as before? It shouldn't be too much work to describe what it means instead (and mention that you are not changing the meaning as a sidenote) to help the readers, something like "The function returns the position in the used_atom[] array (as before) for the given atom, or a negative value to signal an error".