Re: [PATCH 01/11] t9902-completion: add tests demonstrating issues with quoted pathnames
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 17, 2018, 03:48 UTC
- Message-ID
- <xmqq7ep6v6ft.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180416224113.16993-2-szeder.dev@gmail.com>
SZEDER Gábor <szeder.dev@gmail.com> writes:
> Do any more new tests need FUNNYNAMES* prereq?
Hmph, all of these look like they involve some funnynames ;-)
Show 18 quoted lines
> +test_expect_failure 'complete files - escaped characters on cmdline' ' > + test_when_finished "rm -rf \"New|Dir\"" && > + mkdir "New|Dir" && > + >"New|Dir/New&File.c" && > + > + test_completion "git test-path-comp N" \ > + "New|Dir" && # Bash will turn this into "New\|Dir/" > + test_completion "git test-path-comp New\\|D" \ > + "New|Dir" && > + test_completion "git test-path-comp New\\|Dir/N" \ > + "New|Dir/New&File.c" && # Bash will turn this into > + # "New\|Dir/New\&File.c " > + test_completion "git test-path-comp New\\|Dir/New\\&F" \ > + "New|Dir/New&File.c" > +' > + > +test_expect_failure 'complete files - quoted characters on cmdline' ' > + test_when_finished "rm -r \"New(Dir\"" &&
This does not use -rf unlike the previous one?
Show 7 quoted lines
> + mkdir "New(Dir" && > + >"New(Dir/New)File.c" && > + > + test_completion "git test-path-comp \"New(D" "New(Dir" && > + test_completion "git test-path-comp \"New(Dir/New)F" \ > + "New(Dir/New)File.c" > +'
OK.
Show 34 quoted lines
> +test_expect_failure 'complete files - UTF-8 in ls-files output' ' > + test_when_finished "rm -r árvíztűrő" && > + mkdir árvíztűrő && > + >"árvíztűrő/Сайн яваарай" && > + > + test_completion "git test-path-comp á" "árvíztűrő" && > + test_completion "git test-path-comp árvíztűrő/С" \ > + "árvíztűrő/Сайн яваарай" > +' > + > +if test_have_prereq !MINGW && > + mkdir 'New\Dir' 2>/dev/null && > + touch 'New\Dir/New"File.c' 2>/dev/null > +then > + test_set_prereq FUNNYNAMES_BS_DQ > +else > + say "Your filesystem does not allow \\ and \" in filenames." > + rm -rf 'New\Dir' > +fi > +test_expect_failure FUNNYNAMES_BS_DQ \ > + 'complete files - C-style escapes in ls-files output' ' > + test_when_finished "rm -r \"New\\\\Dir\"" && > + > + test_completion "git test-path-comp N" "New\\Dir" && > + test_completion "git test-path-comp New\\\\D" "New\\Dir" && > + test_completion "git test-path-comp New\\\\Dir/N" \ > + "New\\Dir/New\"File.c" && > + test_completion "git test-path-comp New\\\\Dir/New\\\"F" \ > + "New\\Dir/New\"File.c" > +' > + > +if test_have_prereq !MINGW && > + mkdir $'New\034Special\035Dir' 2>/dev/null && > + touch $'New\034Special\035Dir/New\036Special\037File' 2>/dev/null
The $'...' quote is bash-ism, but this is about testing bash completion, so as long as we make sure non-bash shells won't touch this part of the test, it is OK.
Do we want to test a more common case of a filename that is two words with SP in between, i.e.
$ >'hello world' && git add hel<TAB>
or is it known to work just fine without quoting/escaping (because the funny we care about is output from ls-files and SP is not special in its one-item-at-a-time-on-a-line output) and not worth checking?