Re: [PATCH v4 0/3] Add --progress and --dissociate to git submodule

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2018, 02:48 UTC
Message-ID: <xmqq7eo36lpw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180503105346.1758-1-kcghost@gmail.com>

Casey Fitzpatrick <kcghost@gmail.com> writes:

Show 8 quoted lines

> These patches add --progress and --dissociate options to git submodule.
>
> The --progress option existed beforehand, but only for the update command and
> it was left undocumented.
>
> Both add and update submodule commands supported --reference, but not its pair
> option --dissociate which allows for independent clones rather than depending
> on the reference.

This round hasn't seen any further comment, and I think all the previously raised issues have been resolved in this version, so I am tempted to merge it to 'next'.

One thing that I noticed is that "git submodule -h" does not give any hint about --dissociate even though it talks about --reference with these patches applied, and I think it probably should [*1*].

We can make such an update as incremental patch on top of these, if people cared enough about this, without a further reroll of these three patches.

Thanks.

[Footnote]

*1* It's not like we must list each and every option available---it is perfectly fine to omit less common ones to keep the "-h" output manageably short. But I have a feeling that "--reference" and "--dissociate" should probably be at a similar level of importance, and if we list one we probably should show the other, too.