Re: [PATCH v4 2/2] t6120: test for describe with a bare repository
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 1, 2019, 18:53 UTC
- Message-ID
- <xmqq7eejz6fs.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190201135512.68220-2-koraktor@gmail.com>
Sebastian Staudt <koraktor@gmail.com> writes:
Show 21 quoted lines
> This ensures that nothing breaks the basic functionality of describe for > bare repositories. Please note that --broken and --dirty need a working > tree. > > Signed-off-by: Sebastian Staudt <koraktor@gmail.com> > --- > t/t6120-describe.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh > index 7cfed77c52..ea2c3dbe1c 100755 > --- a/t/t6120-describe.sh > +++ b/t/t6120-describe.sh > @@ -418,4 +418,9 @@ test_expect_success 'describe complains about missing object' ' > test_must_fail git describe $ZERO_OID > ' > > +test_expect_success 'describe works from outside repo using --git-dir' ' > + git clone --bare "$TRASH_DIRECTORY" "$TRASH_DIRECTORY/bare" && > + git --git-dir "$TRASH_DIRECTORY/bare" describe > +'
OK, it demonstrates that the command exits with status 0. Do we want to validate its output, too?