git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation/git-bisect.txt: add --no-ff to merge command

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 29, 2019, 03:25 UTC
Message-ID
<xmqq7e4o6xmw.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<xmqq4kzs8f1l.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> As an orthogonal point, I wonder whether we can start the multi-step
>> migration of making --no-commit imply --no-ff by default:
>>
>>  1. Act as --ff when --no-commit is passed without --ff or --no-ff
>>     (the state today)
>
> which means "--no-commit controls whether a new commit is created or
> not and nothing else, and because --ff is the default for merge,
> merging a true descendant will fast-forward".
>
>>  5. Refuse to perform a fast-forward merge with --no-commit is passed
>>     without --ff or --no-ff, just as though --no-ff were passed.
>
> Is that a good endgame, though?

Ah, I was confused by "refuse to perform". You were not trying to make the command fail outright without doing anything. Yes, that would be a good endgame, I would think.

I am not sure if the transition would be smooth, though.
Previous: Junio C Hamano
Message 6 of 6 in “Documentation/git-bisect.txt: add --no-ff to merge command”
  1. Documentation/git-bisect.txt: add --no-ff to merge commandMihail Atanassov, Oct 25, 2019
  2. Jonathan NiederOct 26, 2019
  3. Mihail AtanassovOct 28, 2019
  4. Jonathan NiederOct 28, 2019
  5. Junio C HamanoOct 29, 2019
  6. Junio C HamanoOct 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.