Re: [PATCH v4 10/13] bisect--helper: reimplement `bisect_state` & `bisect_head` shell functions in C
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 8, 2020, 21:38 UTC
- Message-ID
- <xmqq7dvd1yc2.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200701133504.18360-11-mirucam@gmail.com>
Miriam Rubio <mirucam@gmail.com> writes:
Show 12 quoted lines
> @@ -856,6 +858,81 @@ static int bisect_autostart(struct bisect_terms *terms)
>
> return res;
> }
> + int mark_for_removal(const char *refname, const struct object_id *oid,
> + int flag, void *cb_data)
> +{
> + struct string_list *refs = cb_data;
> + char *ref = xstrfmt("refs/bisect%s", refname);
> + string_list_append(refs, ref);
> + return 0;
> +}Funny indentation at the beginning, and worse yet, triggers an error with -Werror=missing-prototypes.
What is the relationship between this one and the similarly-named on in bisect.c?