Re: `git blame` Line Number Off-by-one
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2020, 22:05 UTC
- Message-ID
- <xmqq7duaf6xk.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200807213349.GB1871940@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Dropping it entirely, as below, doesn't break any tests. Junio, do you > know of a case this is meant to improve?
I think the only conceivable case is that in the middle of a single block of text in an ancient version, another block of lines gets inserted during the evolution of the file, but in the end these intermediate edits all go away and the same original text remains.
In such a case, without coalescing, we would not treat the original single block of text as a single unit.
IIRC, blame has some threshold that makes too small a block not subject to move and copy detection, and it is most likely to avoid fragmenting the blocks too small.