Re: permissions of main folder for git-manpages.tar.gz
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 9, 2020, 00:09 UTC
- Message-ID
- <xmqq7dt3x134.fsf@gitster.c.googlers.com>
- In-Reply-To
- <cc8487b0-c23f-46c3-b8c3-e3188b7c0d0e@gmail.com>
Daniel Villeneuve <dvilleneuve.4142@gmail.com> writes:
Show 14 quoted lines
> I am using > https://mirrors.edge.kernel.org/pub/software/scm/git/git-manpages-2.28.0.tar.gz > to get the manpages part of git. > > There has been a change in the permissions of the top-level > folder, from 2.22 (perms 2750) to 2.25 (perms 0700) to 2.28 (perms > 2700). However, the permissions of other files/directories allow > group/others read/execute, as before. > > This change broke my latest installations by preventing group > members to see manpages (I did a chmod to fix that). > > Just sharing this observation, in case the change was not > intentional.
Thanks for letting me know.
The build procedure of these documentation tarballs pretty much just snapshots how I personally have these files locally and not something that was carefully designed to produce files for public consumption.
I'm contemplating to apply something like the following patch to the build procedure so that I can externally control the mode bits recorded in the tarball by setting TAR_C_EXTRA_OPTS to options that overrides mode bits and stuff (it takes GNU tar unfortunately, but I suspect I am the only person that runs dist-doc target anyway)
Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile index 86e5411f39..2a8510f6e6 100644 --- a/Makefile +++ b/Makefile @@ -3041,6 +3041,7 @@ artifacts-tar:: $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) $(OTHER_PROGRAMS) \ $(TAR) czf "$(ARTIFACTS_DIRECTORY)/artifacts.tar.gz" $^ templates/blt/ .PHONY: artifacts-tar +TAR_C_EXTRA_OPTS = htmldocs = git-htmldocs-$(GIT_VERSION) manpages = git-manpages-$(GIT_VERSION) .PHONY: dist-doc distclean @@ -3048,7 +3049,7 @@ dist-doc: $(RM) -r .doc-tmp-dir mkdir .doc-tmp-dir $(MAKE) -C Documentation WEBDOC_DEST=../.doc-tmp-dir install-webdoc - cd .doc-tmp-dir && $(TAR) cf ../$(htmldocs).tar . + cd .doc-tmp-dir && $(TAR) cf ../$(htmldocs).tar $(TAR_C_EXTRA_OPTS) . gzip -n -9 -f $(htmldocs).tar : $(RM) -r .doc-tmp-dir @@ -3058,7 +3059,7 @@ dist-doc: man5dir=../.doc-tmp-dir/man5 \ man7dir=../.doc-tmp-dir/man7 \ install - cd .doc-tmp-dir && $(TAR) cf ../$(manpages).tar . + cd .doc-tmp-dir && $(TAR) cf ../$(manpages).tar $(TAR_C_EXTRA_OPTS) . gzip -n -9 -f $(manpages).tar $(RM) -r .doc-tmp-dir