Re: [PATCH] log: require --grep for --invert-grep and --all-match, fix segfault

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2022, 17:34 UTC
Message-ID: <xmqq7d174m6a.fsf@gitster.g>
In-Reply-To: <patch-1.1-f4b90799fce-20221010T165711Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Neither the "--invert-grep" option added in [1] nor the earlier
> "--all-match" option added in [2] were intended to be used
> stand-alone.

Mostly yes, but with "to be used" -> "to take effect".

"[alias] lga = log --all-match" would be equivalent to "log" unless the command line starts talking about "--grep", which is quite handy.

So the real fix would be not to forbid the standalone passing of the option to the command, but to fix the over-eager freeing of an unallocated resource, introduced more recently, I would suspect.

Thanks.