Re: [PATCH 0/2] builtin/bundle.c: segfault fix style & error reporting follow-up
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 27, 2022, 23:32 UTC
- Message-ID
- <xmqq7cycqv73.fsf@gitster.g>
- In-Reply-To
- <cover-0.2-00000000000-20221227T183708Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 10 quoted lines
> Here's a couple of general improvements on top of ab/bundle-wo-args, > we should also report to the user that they were missing the <file> > argument, as 2/2 here fixes. > > Ævar Arnfjörð Bjarmason (2): > builtin/bundle.c: remove superfluous "newargc" variable > bundle <cmd>: have usage_msg_opt() note the missing "<file>" > > builtin/bundle.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-)
I have no strong opinions on the second one, but the first one is a definite improvement. Will queue both. Thanks.