Re: [PATCH] fix: platform accordance while calculating murmur3

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2024, 18:12 UTC
Message-ID: <xmqq7ckp7ysl.fsf@gitster.g>
In-Reply-To: <pull.1636.git.git.1704376606625.gitgitgadget@gmail.com>

"Chen Xuewei via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: Chen Xuewei <316403398@qq.com>
>
> It is known that whether the highest bit is extended when char cast to
> uint32, depends on CPU architecture, which will lead different hash
> value. This is a fix to accord all architecture behaviour.
>
> Signed-off-by: Chen Xuewei <316403398@qq.com>
> ---

Jonathan and Taylor, isn't this what you two were working together on? How would we want to proceed?

Chen, using the right implementation of the hash function to be used after the next rebuild of the Bloom data has so far been treated as only one part of the solution (the others include "how to deal with the existing data? do we have a way to tell our binary to safely ignore the Bloom data using a wrong hash?" and "how to make sure old binaries do not get confused by the Bloom data using the right/new hash?").

Jonathan and Taylor's (stalled) effort is here

    https://lore.kernel.org/git/cover.1697653929.git.me@ttaylorr.com

Thanks.