Re: [PATCH] GIT-VERSION-GEN: allow it to be run in parallel

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2025, 20:00 UTC
Message-ID: <xmqq7c73iwqc.fsf@gitster.g>
In-Reply-To: <CAN0heSo2pFmfx=zJgx2T6y+W1tG_PTXxf6uk2kBgi4c0kXz_oQ@mail.gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

Show 6 quoted lines

>> ... attempts to remedy this in git/git were unsuccessful, see e.g.
>> https://lore.kernel.org/git/pull.216.git.gitgitgadget@gmail.com/
> ...
> You could use "$OUTPUT"."$$"+ to restore this. That of course
> invalidates your remark about "Incidentally, ..." above, but might give
> this fix a tiny bit less chance of regressing something somewhere?

Thanks for being careful.

My reading of that old thread cited there tells me that the reason that previous one failed was mostly because it wasn't being self consistent and only touched the use of "+" in the Documentation directory but not what the top-level Makefile did, and also because it did not adjust .gitignore patterns, so it is good that somebody actually read the cited thread and made sure this time we do better.

Again, I was not opposed to moving from "+" to something else that is equally short-and-sweet, and I still am not ("~" is a fine suffix for this kind of thing, for example). But if we are aiming for a short-term fix, I think your ".$$+" may make the most sense.

Thanks.