Re: What's cooking in git.git (Oct 2026, #06)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2026, 17:46 UTC
Message-ID: <xmqq7bjbosj6.fsf@gitster.g>
In-Reply-To: <athRc1-tSEVgBupp@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 14 quoted lines

> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
> index 16cc5d5dcb..a19bb27db7 100755
> --- a/t/t1450-fsck.sh
> +++ b/t/t1450-fsck.sh
> @@ -544,6 +544,7 @@ test_expect_success 'rev-list --verify-objects with truncated loose blob' ' 
>  		cd truncated-blob &&
>  		blob=$(test-tool genrandom one 5k | git hash-object -t blob -w --stdin) &&
>  		obj=.git/objects/$(test_oid_to_path $blob) &&
> +		chmod +w $obj &&
>  		# Truncate the loose blob such that its header can still be
>  		# parsed, but reading the object data fails mid-stream.
>
> Ah, right, that makes sense. Makes me wonder why none of our tests in CI
> hit this error. Weird.

Not just CI. I haven't seen this fail locally, either. Is the breakage Torsten reports that the later step

	mv obj.tmp "$obj"

fail when $obj" is not writable?  That does not make sense to me.

> Junio, as this patch series is already in "next", do you want me to send
> a patch on top to fix it or shall I send a new version?

A separate patch on top is very much appreciated.

Thanks.