git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 06/10] fast-export: add new --refspec option

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2013, 18:26 UTC
Message-ID
<xmqq61sd70vw.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1383212197-14259-6-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> +test_expect_success 'use refspec' '
> +	git fast-export --refspec refs/heads/master:refs/heads/foobar master | \
> +		grep "^commit " | sort | uniq > actual &&

It feels somewhat redundant that you have to twice say that you are pushing your "master", once with --refspec and then the branch name. Is this the best we can do?

If the answer is "yes", I guess it is OK to leave the external interface to fast-export of this patch as-is, but if we can do better, then we'd be better off without redundancy.

There are quite a few shell script style violations in this test, by the way. You do not want the trailing " \" after a pipe (the shell, when seeing a line that ends with "|", knows you haven't finished giving it the pipeline). Also we do not put extra space between a redirection operator and the target filename.

Show 5 quoted lines
> +	echo "commit refs/heads/foobar" > expected &&
> +	test_cmp expected actual
> +'
> +
>  test_done
Previous: Felipe ContrerasNext: Felipe Contreras
Message 19 of 45 in “transport-helper: add support to delete branches”
  1. 10/10 transport-helper: add support to delete branchesFelipe Contreras, Oct 31, 2013
  2. 00/10 transport-helper: updatesFelipe Contreras, Oct 31, 2013
  3. Max HornOct 31, 2013
  4. Junio C HamanoOct 31, 2013
  5. Felipe ContrerasOct 31, 2013
  6. Junio C HamanoOct 31, 2013
  7. Max HornOct 31, 2013
  8. 11/10 test-hg.sh: tests are now expected to passRichard Hansen, Nov 11, 2013
  9. 12/10 remote-bzr: support the new 'force' optionRichard Hansen, Nov 11, 2013
  10. Felipe ContrerasNov 11, 2013
  11. Richard HansenNov 11, 2013
  12. Felipe ContrerasNov 11, 2013
  13. 01/10 transport-helper: fix extra linesFelipe Contreras, Oct 31, 2013
  14. Junio C HamanoOct 31, 2013
  15. 08/10 fast-import: add support to delete refsFelipe Contreras, Oct 31, 2013
  16. Max HornOct 31, 2013
  17. 05/10 fast-export: improve argument parsingFelipe Contreras, Oct 31, 2013
  18. 06/10 fast-export: add new --refspec optionFelipe Contreras, Oct 31, 2013
  19. Junio C HamanoOct 31, 2013
  20. Felipe ContrerasOct 31, 2013
  21. Junio C HamanoNov 6, 2013
  22. Jeff KingNov 6, 2013
  23. Junio C HamanoNov 6, 2013
  24. Junio C HamanoNov 6, 2013
  25. Junio C HamanoNov 8, 2013
  26. Jeff KingNov 9, 2013
  27. Felipe ContrerasNov 7, 2013
  28. 03/10 transport-helper: add 'force' to 'export' helpersFelipe Contreras, Oct 31, 2013
  29. Junio C HamanoOct 31, 2013
  30. Felipe ContrerasOct 31, 2013
  31. Junio C HamanoOct 31, 2013
  32. Junio C HamanoNov 1, 2013
  33. Felipe ContrerasNov 1, 2013
  34. Junio C HamanoNov 1, 2013
  35. Eric SunshineNov 1, 2013
  36. fixup! transport-helper: add 'force' to 'export' helpersRichard Hansen, Nov 11, 2013
  37. 09/10 fast-export: add support to delete refsFelipe Contreras, Oct 31, 2013
  38. Max HornOct 31, 2013
  39. Felipe ContrerasOct 31, 2013
  40. Max HornOct 31, 2013
  41. Felipe ContrerasOct 31, 2013
  42. Max HornOct 31, 2013
  43. 07/10 transport-helper: add support for old:new refspecFelipe Contreras, Oct 31, 2013
  44. 04/10 transport-helper: check for 'forced update' messageFelipe Contreras, Oct 31, 2013
  45. 02/10 transport-helper: don't update refs in dry-runFelipe Contreras, Oct 31, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.