Re: [PATCH] Update SVN.pm

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2014, 19:13 UTC
Message-ID: <xmqq61m9gka6.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140416141605.GA9692@camelia.ucw.cz>

Stepan Kasal <kasal@ucw.cz> writes:

Show 8 quoted lines

> From: RomanBelinsky <belinsky.roman@gmail.com>
> Date: Tue, 11 Feb 2014 18:23:02 +0200
>
> fix parsing error for dates like:
> 2014-01-07T5:58:36.048176Z
> previous regex can parse only:
> 2014-01-07T05:58:36.048176Z
> reproduced in my svn repository during conversion.

Interesting. What other strange forms can they record in their repositories, I have to wonder. Can they do

    2014-01-07T5:8:6.048176Z

for example? I am wondering if it is simpler and less error prone to turn all these "we only accept two digits" into "\d+" not only for the hour part but also minute and second parts.

Show 17 quoted lines

> Signed-off-by: Stepan Kasal <kasal@ucw.cz>
> ---
>  perl/Git/SVN.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> index a59564f..09cff13 100644
> --- a/perl/Git/SVN.pm
> +++ b/perl/Git/SVN.pm
> @@ -1321,7 +1321,7 @@ sub get_untracked {
>  sub parse_svn_date {
>  	my $date = shift || return '+0000 1970-01-01 00:00:00';
>  	my ($Y,$m,$d,$H,$M,$S) = ($date =~ /^(\d{4})\-(\d\d)\-(\d\d)T
> -	                                    (\d\d)\:(\d\d)\:(\d\d)\.\d*Z$/x) or
> +	                                    (\d\d?)\:(\d\d)\:(\d\d)\.\d*Z$/x) or
>  	                                 croak "Unable to parse date: $date\n";
>  	my $parsed_date;    # Set next.